Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert on Dual #166

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix convert on Dual #166

merged 2 commits into from
Aug 14, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Aug 13, 2024

Bug spotted in the context of #164. Still needs tests before merging.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (199899d) to head (882ce86).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   92.70%   92.80%   +0.09%     
==========================================
  Files          37       37              
  Lines        1590     1598       +8     
==========================================
+ Hits         1474     1483       +9     
+ Misses        116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill marked this pull request as ready for review August 14, 2024 16:17
@adrhill adrhill merged commit 8587e0d into main Aug 14, 2024
6 checks passed
@adrhill adrhill deleted the ah/convert-bug branch August 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants